fix: handle derivatives of time-dependent parameters #3493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But also test that the derivative of say a datainterpolation is non-zero still. |
|
Was this found to be okay / safe? |
|
Not completely. We don't always want the derivative of a discrete parameter to be zero. One such example is CoSimulation FMUs. The spec enables getting derivatives of outputs, and sometimes MTK needs this information (e.g. if the output of an FMU is in an equation that pantelides differentiates). I think the solution is to allow |
AayushSabharwal
force-pushed
the
as/param-derivatives
branch
from
4d7bb2f to
105dd72
Compare
baggepinnen
approved these changes
Apr 22, 2025
| using ModelingToolkit: t_nounits as t, D_nounits as D | ||
|
|
||
| sts = @variables x1(t) x2(t) x3(t) x4(t) | ||
| params = @parameters u1(t) u2(t) u3(t) u4(t) |
AayushSabharwal
force-pushed
the
as/param-derivatives
branch
from
e660b0b to
a2b4745
Compare
ChrisRackauckas
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3480